| zzag |
| KWin |
This removes the restart function of the Compositor class and renames the
internal reinitialize function.
Instead of the restart function reinitialize can be called. Reading again
the settings in this case is fine, since it is done rarely. This reduces
the code complexity.
Manually on Wayland and X. 100% autotests pass.
| Lint OK |
| No Unit Test Coverage |
| Buildable 13595 | |
| Build 13613: arc lint + arc unit |
This removes the dbus method to reinit the compositor
No, no, no. It's used by Compositing KCN.
Have you measured how long it takes to reinitialize and restart compositor? Could you please share with us numbers?
I have not and I also don't plan on doing it. restart is called once in the constructor (where we need to read in the config anyway), when the default refresh rate changes or when the scene registered an Gl error. So in 99.9999999999% of sessions this call should be made exactly once.
| composite.h | ||
|---|---|---|
| 116 ↗ | (On Diff #61043) | Not your fault, but that all 3 parts of that documentation are wrong. The service name isn't part of the match rule. The path is /Compositor The method is "org.kde.kwin.Compositing.reinit" Probably why you didn't see it was used. |
| composite.cpp | ||
|---|---|---|
| 597 | No, 1c2ba6ea17bd adds it 10 years ago without more info. Nowadays restart() was either called on a different timer. so it should not have any influence or on Scene::resetCompositing. Didn't test if it has some sort of impact there, but I would just assume that it doesn't since in the reinitialize call we also do it timer-less without issues. | |