Please reindent it to

enum SuspendReason {
    NoReasonSuspend,
    UserSuspend = 1 << 0,
    // ...
};

Why is it Q_INVOKABLE?

There is a invokeMethod call to it.

In general I don't see why making it Q_INVOKABLE is better than keeping as a slot. Either keep it as Q_SLOT or use QTimer::singleShot(0).

Please keep it protected.

Why not Q_INVOKABLE?

Reply to what I asked first in this context.

Wrong by what arbitrary rule? Two stars is wrong when looking at upstream recommendation and other projects. I told you this already half a year ago after you went through reformatting all the code base. Still you insist on that being the "right" way to do it. We should use one star at the end of Doxygen comments consistently for new comments.

And this reformatting was done without checking back on my opinion on that first although quite a lot of that code was written by me and I'm an active core contributor to KWin longer than you.

Similarly just a few days ago you reformatted my complete XWayland drag-and-drop code to your personal code rules without review or even saying anything beforehand. I hope there won't be again an excuse for you to not come to a meetup so we can discuss your behavior in regards to code styling and review etiquette later this month at the KWin sprint.

Listen, put yourself in my shoes. I see a code base with some certain coding style, and your patch follows slightly different style. Do you even realize that such small disagreements contribute to coding style masquerade?

If you don't like the current doxygen style, then submit a patch to change it to a more main stream style. Running git grep + sed with s/ \*\*\// \*\// should be enough. I'll accept that patch, and I think any fellas from Plasma do the same.

Also, I find it a bit frustrating that a lot of time goes into disputing coding style. If you don't like something, stick with it for a moment, but don't invent "new style." Address the issue in another patch.

and I'm an active core contributor to KWin longer than you.

OK.

Yea, let's talk about this at the sprint. Just so we understand each other correctly: I don't have anything against you personally and I value your expertise and hard work on KWin.

Different people just have different styles of solving problems and if that's not organized correctly this might clash. We need to organize our project such that it suits the project, us and other part-time contributors and the KWin sprint will give us opportunity to do that.