Differential D22162

taskmanager: performance
ClosedPublic
Actions

Authored by apol on Jun 30 2019, 10:05 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R120:50c391cc6c1b: taskmanager: performance
Summary

Don't do queries on unknown values.
Don't create a KDesktopFile until we know we're going to need it

Test Plan

Ran plasma with debugs, didn't see any regressions.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jun 30 2019, 10:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 30 2019, 10:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jun 30 2019, 10:05 AM
ngraham added a subscriber: ngraham.Jun 30 2019, 1:09 PM

Not sure if it's related, but while you're at it, would you be able to also fix these errors when hovering over a pinned item:

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347: Unable to assign [undefined] to int
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375: TypeError: Type error
hein accepted this revision.Jul 2 2019, 3:04 PM
hein added a subscriber: hein.
In D22162#488378, @ngraham wrote:

Not sure if it's related, but while you're at it, would you be able to also fix these errors when hovering over a pinned item:

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347: Unable to assign [undefined] to int
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375: TypeError: Type error

They're not related, so shouldn't be handled in this review (see also fregl's patches).

This revision is now accepted and ready to land.Jul 2 2019, 3:04 PM
Closed by commit R120:50c391cc6c1b: taskmanager: performance (authored by apol). · Explain WhyJul 2 2019, 3:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibtaskmanager/tasktools.cpp (21 lines)

Diff 61012

View Options

libtaskmanager/tasktools.cpp

Loading...