Differential D22128

[Kickoff] Redo tab bar separator's geometry
ClosedPublic
Actions

Authored by filipf on Jun 27 2019, 10:03 PM.

Details

Reviewers
ndavis
ngraham
Group Reviewers
Plasma
VDG
Commits
R119:76045bf20e07: [Kickoff] Redo tab bar separator's geometry
Summary

This patch makes Kickoff tab indicators glide (patch D22108) on the tab bar separator in all 4 orientations.

I had to give up on the separator matching the width\height of the tab indicators because it was just never pixel perfect.

Test Plan

Screenshots made with patch D22108 applied

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jun 27 2019, 10:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 27 2019, 10:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jun 27 2019, 10:03 PM
filipf edited the summary of this revision. (Show Details)Jun 27 2019, 10:07 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG.
ndavis added a subscriber: ndavis.Jun 27 2019, 11:58 PM

Why is the tab highlight thicker in these


And thinner in these?


ndavis added a comment.EditedJun 28 2019, 12:06 AM

Since these seem to be scaled 2x, the thicker 6px highlight is more desirable. At 1x, the highlight should be 3px.

filipf added a comment.Jun 28 2019, 8:36 AM

Don't know, I removed both of the patches and the issue's still there. Yeah this was 2x scaling and the indicator should be 6px.

ngraham added a subscriber: ngraham.Jun 28 2019, 8:52 PM

Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen):

filipf added a comment.Jun 28 2019, 8:58 PM
In D22128#487943, @ngraham wrote:

Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen):

Hmm, am I patching the wrong thing in D22108? I wanted to be editing this file:

/usr/lib/qt/qml/org/kde/plasma/components/TabBar.qml
ndavis accepted this revision.Jun 28 2019, 9:34 PM
In D22128#487943, @ngraham wrote:

Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen):

Same here.

This revision is now accepted and ready to land.Jun 28 2019, 9:34 PM
ndavis requested changes to this revision.Jun 28 2019, 9:35 PM

whoops, didn't mean to accept

This revision now requires changes to proceed.Jun 28 2019, 9:35 PM
ndavis accepted this revision.EditedJun 28 2019, 9:38 PM

Sorry, my bad once again. I hadn't actually applied D22108. It works for me now. The tab highlight width problem must be somewhere else since this patch didn't introduce that bug.

This revision is now accepted and ready to land.Jun 28 2019, 9:38 PM
ngraham accepted this revision.Jun 30 2019, 8:19 PM
In D22128#487965, @ndavis wrote:

Sorry, my bad once again. I hadn't actually applied D22108. It works for me now. The tab highlight width problem must be somewhere else since this patch didn't introduce that bug.

Oh, I must have made the same mistake, because upon trying again it now works.

We should also make the tab highlight look like the new style in T11124. :)

filipf added a comment.Jul 1 2019, 8:53 PM

Can anyone from Plasma have a quick look if this is okay?

I went with the approach of not initially defining geometry, and define it only as a part of the anchor changes?

Closed by commit R119:76045bf20e07: [Kickoff] Redo tab bar separator's geometry (authored by filipf). · Explain WhyJul 4 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61179

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...