the background of the view selector list should be transparent
ClosedPublic

Authored by mgallien on Jun 25 2019, 5:44 AM.

Details

Summary

avoid having a big rectangle with a default color not following the
color theme

BUG: 408435

Test Plan

now playlist is correct with Breeze and BreezeDark

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Jun 25 2019, 5:44 AM
mgallien created this revision.
zanny accepted this revision.Jun 25 2019, 5:53 AM
zanny added a subscriber: zanny.

πŸ‘

This revision is now accepted and ready to land.Jun 25 2019, 5:53 AM

Do we even need this Rectangle at all? Now that it's transparent, and its border has the same color as what's beneath it, I think it can just be removed entirely. I tried this out and couldn't find any visual difference whatsoever.

neousr added a subscriber: neousr.Jun 25 2019, 3:13 PM

Removing the rectangle seems to have no visible effect at all. By all means it gets the same result as the current patch.

mgallien updated this revision to Diff 60650.Jun 25 2019, 3:25 PM
  • remove the background rectangle that used to indicate the active focus

remove the rectangle that used to indicate the active focus state

ngraham accepted this revision.Jun 25 2019, 3:26 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the tests and the review.