Show an entry on the system tray indicator when a portal is needed
ClosedPublic

Authored by apol on Jun 24 2019, 4:00 PM.

Details

Summary

This way it's still accessible if I lose the notification somehow.

Test Plan

I don't get it when connected normally on the internet. I managed to reach the portal when on the plane.

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13272
Build 13290: arc lint + arc unit
apol created this revision.Jun 24 2019, 4:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 24 2019, 4:00 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jun 24 2019, 4:00 PM
jgrulich accepted this revision.Jun 25 2019, 6:15 AM
This revision is now accepted and ready to land.Jun 25 2019, 6:15 AM
ngraham added inline comments.
applet/contents/ui/main.qml
61

This icon has no monochrome version, so it will stick out in the system tray where other icons are generally monochrome.

If this is not intended, a better icon would be internet-services, which is monochrome only.

This revision was automatically updated to reflect the committed changes.
tuxflo added a subscriber: tuxflo.Jul 1 2019, 1:59 PM

Instead of just notifying about a captive portal, one should be able to auto accept the useless "do you really agree" buttons like this project: https://github.com/makefu/prison-break