Differential D22075

[Notifications] Swap configure and clear buttons in full representation header
ClosedPublic
Actions

Authored by broulik on Jun 24 2019, 3:35 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R120:11387ca37f91: [Notifications] Swap configure and clear buttons in full representation header
Summary

This makes it consistent with the configure button of the items in the list below.

BUG: 409140
FIXED-IN: 5.16.2

Test Plan


When the history is empty, the clear button is disabled instead of hidden to keep the configure button from shifting around

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jun 24 2019, 3:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 24 2019, 3:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 24 2019, 3:35 PM
ngraham accepted this revision.Jun 24 2019, 3:54 PM
This revision is now accepted and ready to land.Jun 24 2019, 3:54 PM
Closed by commit R120:11387ca37f91: [Notifications] Swap configure and clear buttons in full representation header (authored by broulik). · Explain WhyJun 24 2019, 5:40 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Aug 1 2019, 8:19 PM

In retrospect, while this makes it consistent with what's below it, it's now inconsistent with all the other system tray pop-ups, which put their Settings button all the way over to the right.

Hmm.

Revision Contents
Changeset List

Diff 60588

View Options

applets/notifications/package/contents/ui/FullRepresentation.qml

Loading...