Disable logs unless the logging category kf5.kconfig.core is enabled
Details
- Reviewers
apol krop - Group Reviewers
Frameworks - Commits
- R237:403c617eea56: Add a logging category for logs warnings
ctest
Diff Detail
- Repository
- R237 KConfig
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13255 Build 13273: arc lint + arc unit
src/core/kdesktopfile.h | ||
---|---|---|
27 ↗ | (On Diff #60545) | Use ecm_qt_declare_logging_category from cmake. This should never be in header files too, or it would spill on applications otherwise. See for example how it's done in this same repo on KCONF_UPDATE_LOG. |
Thank you very much again @apol for your guidance.
I am not sure my naming scheme is ideal.
src/core/CMakeLists.txt | ||
---|---|---|
19 | This is for KF5ConfigCore, I'd call it kf5.kconfig.core. |
The patch looks good to me.
I see that you're just doing KDesktopFile, but there's many others available, can you port the rest too?
CMakeLists.txt | ||
---|---|---|
102 ↗ | (On Diff #61897) | This line is not useful |
src/core/CMakeLists.txt | ||
17 | the framework is called kconfig, the public headers are called kconfig*.h, there's no reason to truncate the framework name. Also, why 'deskop' in the name ? this is for kconfigcore. kconfigcore_debug.h sounds better |
Rename kconf_desktop_debug.h to more appropriate kconfig_core_log_settings.h, do not run an unnecessary install
I have opted for the file name kconfig_core_log_settings.h for the log settings header file.
ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine.
Renamed kconf to kconfig, KCONF to KCONFIG, re-add the mistakenly removed categories file