Nice first patch!

For visual changes like this, please tag VDG and provide before and after screenshots in the Test Plan section. Thanks!

You are right, the "Search" and "Next" buttons should be grouped with the search combo box and the same applies for "Replace" and "Replace Checked". On the other hand, I think it would be nice to have large find and replace combo boxes. Thus, we don't want to eat too much space with other widgets in the same row.
I suggest the following :

• add icons and help tooltips to the "Replace" and "Replace Checked" buttons
• when the view is narrow, move the search combo box along with the "Search" and "Next" buttons on their own row; remove the button texts; remove the "Find" label. The same applies for the replace group.
• when the view is large, restore the original view

This way, the buttons are grouped logically, the combo boxes are large and someone who use it for the first time knows how to use the buttons even if there is no text in the buttons.

I will add the resulting screenshots in the test plan.

What do you think?

I dunno, I'm having a hard time thinking of icons that could communicate "replace" and "replace checked" in this context. But maybe it would work. Give it a shot and see! :)

What if we put the search combo on one row and the search and next buttons on the next row together with the search places combo.
Then the next row would be the replace combo with the replace buttons and tool buttons on the next?

I added a screenshot based on the last comment. Buttons are grouped depending on their relation to "find" (including the show search options button) or to replace/result (including Expand result and Add Tab).

All buttons have the auto raise option set to false. I do not know the precise meaning of this option, I made this change to have a consistent view.

Indeed, the Replace and Replaced Checked button icons do not fit that well, we can remove these icons.

Also, the "find" label may be changed to "Search" since the button is labeled "Search".

Of the options, I like the third one best.

Sorry for the late review.

I like this last layout! :)

I'm not totally convinced about the QPushButton to QToolButton change. The idea is that the "options" behave more like check-boxes and that the other "real-looking" buttons execute an action when clicked.

Is it intended that there is a double space between the next button and search place combo?

With the minor fixes to the tool-tips and maybe a revert of the button types I would be ready to commit this.

I am a bit concerned about the height increase. As most people have 16:9/10 screens, screen height is always sparse.

Ok, I see, for the search stuff at the left/right, it makes sense, thought I normaly keep it at the bottom.

Ok. Note that the layout is still the one you currently use when toolview is at the bottom (when toolview.width >= toolview.height)

:=) I see, I should have properly read the description.

Then I will not bitch anymore here .P

Looks good for me, too, was just ignorant.

Hmm, munging the layout that's provided by the UI file in QWidgets code doesn't sit that well with me (especially grid layout code, which is already quite difficult to read). Is there no other way?

Thanks for taking care of this!
Both to the submitter of the patch and all reviewers.