Differential D22041

[Avatar Gallery] Increase minimum width
ClosedPublic
Actions

Authored by filipf on Jun 23 2019, 12:30 PM.

Details

Reviewers
ngraham
ndavis
Group Reviewers
VDG
Commits
R128:82fe6ba3830b: [Avatar Gallery] Increase minimum width
Summary

3 entries now fit in a row instead of 2.

Test Plan

Diff Detail

Repository
R128 User Manager
Branch
wider-avatar-gallery-by-default (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13216
Build 13234: arc lint + arc unit
filipf created this revision.Jun 23 2019, 12:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 23 2019, 12:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jun 23 2019, 12:30 PM
filipf edited the test plan for this revision. (Show Details)Jun 23 2019, 12:31 PM
filipf added reviewers: VDG, ngraham, ndavis.
ngraham accepted this revision.Jun 23 2019, 12:39 PM

Shipit! Stable branch please.

This revision is now accepted and ready to land.Jun 23 2019, 12:39 PM
filipf added a comment.Jun 23 2019, 12:44 PM
In D22041#485251, @ngraham wrote:

Shipit! Stable branch please.

I don't have an earlier copy now, but IIRC there were enough thumbnails in a row before, it's only when we added the new Konqi ones that the thumbnails increased in width.

ngraham added a comment.Jun 23 2019, 12:45 PM

Oh right, because they're wider now.

ndavis accepted this revision.Jun 23 2019, 12:46 PM
Closed by commit R128:82fe6ba3830b: [Avatar Gallery] Increase minimum width (authored by filipf). · Explain WhyJun 23 2019, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/avatargallery.ui (6 lines)

Diff 60473

View Options

src/avatargallery.ui

Loading...