[Service Runner] Search through "Comment" as well
ClosedPublic

Authored by broulik on Jul 18 2016, 12:01 PM.

Details

Summary

Kickoff traditionally prefers showing the application comment (ie. "File Manager", "Web Browser", etc) over the actual application name. This allows to find applications this way.

Test Plan
  • searched for "File manager", found Dolphin
  • searched for "drop-down", found Yakuake
  • searched for "Browser", got Chrome and Firefox (though default applications KCM or whatever this is called came topmost because /names/ have higher priority)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5268.Jul 18 2016, 12:01 PM
broulik retitled this revision from to [Service Runner] Search through "Comment" as well.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 18 2016, 12:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Jul 18 2016, 12:02 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jul 18 2016, 12:02 PM

I'm pretty sure I remember a conversation with Vishesh where he deliberately didn't do this because the results then look utterly random as you can't see the comment.

I'm pretty sure I remember a conversation with Vishesh where he deliberately didn't do this because the results then look utterly random as you can't see the comment.

I changed it so the comment is shown at least when the item is currently selected in the list [1] as it often provides useful information, not just for telling apart similar entries (as the old logic did).

[1] https://quickgit.kde.org/?p=milou.git&a=commit&h=f6d6e60c8e9e50d68b6d30a859bfff1cb573ed30

Big +1, both showing and being able to search in the description is crucial especially for newer users who have not memorized the often entirely arbitrary application names.

This revision was automatically updated to reflect the committed changes.