Improve QWidget KCM and QML KCM consistency
ClosedPublic

Authored by meven on Sun, Jun 23, 10:52 AM.

Details

Summary
  • Set QWidget KCMs title font size to the same one as QML ones
  • Add content margin to QWidget KCMs to match QML ones
  • Only display own KCM title in QML case

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Sun, Jun 23, 10:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Jun 23, 10:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Sun, Jun 23, 10:52 AM
meven updated this revision to Diff 60446.Sun, Jun 23, 10:55 AM

Remove lines that shouldn't have been included

Close! But the title sizes still appear to differ:

meven updated this revision to Diff 60484.Sun, Jun 23, 1:08 PM

Adjust font size

meven updated this revision to Diff 60485.Sun, Jun 23, 1:09 PM

Remove changes that will go to another review

mart accepted this revision.Mon, Jun 24, 8:03 PM
This revision is now accepted and ready to land.Mon, Jun 24, 8:03 PM
ngraham accepted this revision.Mon, Jun 24, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Could this be backported to the stable branch? It's a relative straightforward bugfix.

meven added a comment.Tue, Jun 25, 4:32 PM

Could this be backported to the stable branch? It's a relative straightforward bugfix.

Unfortunately no, it would cause a bug without the D20598 diff that added a title to the kinfocenter, causing the need here to remove the titles for QML KCM.

Gotcha, thanks!