Differential D21991

Add X-KDE-ParentApp entries in metadata.desktop
AbandonedPublic
Actions

Authored by bshah on Jun 22 2019, 11:16 AM.

Details

Reviewers

apol
ngraham

Commits

R120:53d45a126e5d: Add X-KDE-ParentApp entries in metadata.desktop

Summary

If this entry is not added, kpackagetool5 tries to load the specific
packagestructure plugin, fails to load it and then writes the metainfo
as it is "application" instead of add-on

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bshah created this revision.Jun 22 2019, 11:16 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 11:16 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bshah requested review of this revision.Jun 22 2019, 11:16 AM

Harbormaster completed remote builds in B13134: Diff 60323.Jun 22 2019, 11:16 AM

ngraham accepted this revision.Jun 22 2019, 11:19 AM

This revision is now accepted and ready to land.Jun 22 2019, 11:19 AM

Closed by commit R120:53d45a126e5d: Add X-KDE-ParentApp entries in metadata.desktop (authored by bshah). · Explain WhyJun 22 2019, 12:36 PM

This revision was automatically updated to reflect the committed changes.

broulik reopened this revision.Jun 23 2019, 11:30 AM

broulik added a subscriber: broulik.

broulik added inline comments.

applets/notifications/package/metadata.desktop
150	This causes the notification plasmoid to not show up in system tray anymore

This revision is now accepted and ready to land.Jun 23 2019, 11:30 AM

I've reverted this change now and have come up with more nicer solution in kpackagetool5, will open PR for it.

Revision Contents
Changeset List

			Path	Packages
M			applets/digital-clock/package/metadata.desktop (2 lines)
M			applets/notifications/package/metadata.desktop (2 lines)
M			wallpapers/color/metadata.desktop (2 lines)
M			wallpapers/image/imagepackage/metadata.desktop (2 lines)
M			wallpapers/image/slideshowpackage/metadata.desktop (2 lines)