Differential D21951

[keyboardindicator] Set Plasmoid to hidden if no lock is active
Needs RevisionPublic
Actions

Authored by nicolasfella on Jun 21 2019, 9:18 AM.

Details

Reviewers
ngraham
apol
Group Reviewers
Plasma
Summary

It's not useful. Let's hide it

Diff Detail

Repository
R114 Plasma Addons
Branch
hide
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13059
Build 13077: arc lint + arc unit
nicolasfella created this revision.Jun 21 2019, 9:18 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 21 2019, 9:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jun 21 2019, 9:18 AM
This revision is now accepted and ready to land.Jun 21 2019, 9:25 AM
broulik added a subscriber: broulik.Jun 21 2019, 9:31 AM

Again the problem that you can configure the plasmoid to work on different modifier keys potentially locking you out of the applet settings.

apol requested changes to this revision.Jun 21 2019, 10:43 AM
apol added a subscriber: apol.

As @broulik says, this wasn't done because then it's impossible to configure without pressing the key.

I don't think it should go in without an alternative.

This revision now requires changes to proceed.Jun 21 2019, 10:43 AM

Revision Contents
Changeset List

Diff 60191

View Options

applets/keyboardindicator/contents/ui/main.qml

Loading...