Have more contrast in circle-style user avatars
ClosedPublic

Authored by filipf on Jun 20 2019, 1:29 PM.

Details

Summary

Our circular avatar currently don't have the best contrast between their background and main element, which is especially evident when using light themes.

This patch raises the opacity of the background circle, making it more prominent.

Test Plan

Before & After (Breeze):

Before & After (Breeze Dark)

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jun 20 2019, 1:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 20 2019, 1:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jun 20 2019, 1:29 PM

Looks like the permissions have changed too?

filipf edited the test plan for this revision. (Show Details)Jun 20 2019, 1:31 PM
filipf added reviewers: VDG, ngraham, ndavis.
filipf updated this revision to Diff 60120.Jun 20 2019, 1:33 PM
filipf edited the test plan for this revision. (Show Details)

fix permissions

filipf updated this revision to Diff 60122.Jun 20 2019, 1:41 PM

fix permissions, take 2

ngraham accepted this revision.Jun 20 2019, 1:42 PM

There we go, much better. Thanks!

This revision is now accepted and ready to land.Jun 20 2019, 1:42 PM

Unless you want to get rid of the SVG these avatars were created from, you should also update pics_sources/avatar.svg.

filipf planned changes to this revision.Jun 20 2019, 10:10 PM

Good catch. I'll need a bit of help with that but should be doable.

filipf updated this revision to Diff 60225.Jun 21 2019, 12:43 PM

also edit the svg
change the style a bit

This revision is now accepted and ready to land.Jun 21 2019, 12:43 PM
filipf edited the test plan for this revision. (Show Details)Jun 21 2019, 12:44 PM
ndavis accepted this revision.Jun 21 2019, 3:23 PM
This revision was automatically updated to reflect the committed changes.