Non-ASCII characters from CD-info are replaced with '?' by default in Latin1. This patch tries to use Unicode conversion.
BUG: 406262
Details
Details
- Reviewers
cfeck - Group Reviewers
KDE Applications - Commits
- R342:2197d5d47617: Use Unicode by default for CD-info data
- Put some Audio-CD with known Unicode characters in the song titles (Cyrillic, Chinese, Korean, Greek, English with em-dashes or apostrophes).
- Choose to open it in Dolphin.
- Open "Information -> CDDB Information.txt".
- All Unicode chars should be shown as expected.
Diff Detail
Diff Detail
- Repository
- R342 KIO AudioCD
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Why does the commit message say "tries to" and "should be"? Could you actually test it and verify it?
Comment Actions
I tested it on my very limited collection of Audio-CDs (3 pieces now, Cyrillic, Ukrainian, Russian). It may not work otherwise. I just put this revision here in hope that someone can test it.
Sorry for the noise, if it is inappropriate.
Comment Actions
If it works with cyrillic in UTF-8, it should indeed also work with any other scripts.
Comment Actions
if you're bored you can improve the code (it was bad before already, not your fault) removing the QByteArray( ) toUtf8 is already a bytearray