Differential D21792

[PendingFileQueue] Refactor for easier and faster unit testing
ClosedPublic
Actions

Authored by bruns on Jun 13 2019, 11:23 PM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Commits
R293:b359101424d8: [PendingFileQueue] Refactor for easier and faster unit testing
Summary

Supply the current time as an argument to the slots, so the slots can
be called with artificial timestamps, decoupling it from the wall time.

Test Plan

ctest -R pendingfilequeuetest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jun 13 2019, 11:23 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 13 2019, 11:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 13 2019, 11:23 PM
ngraham accepted this revision.Jun 14 2019, 2:35 PM
This revision is now accepted and ready to land.Jun 14 2019, 2:35 PM
Closed by commit R293:b359101424d8: [PendingFileQueue] Refactor for easier and faster unit testing (authored by bruns). · Explain WhyJun 14 2019, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 59820