Prefer document.title over sender.tab.title
ClosedPublic
Actions

Authored by broulik on Jun 11 2019, 8:02 AM.

Details

Reviewers

fvogt
davidedmundson

Group Reviewers

Plasma

Commits

Summary

In case the media player is embedded in an iframe

Test Plan

Played a video that was in an iframe, got its title now instead of the "generic" website one it was embedded in.
Should be backwards compatible

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jun 11 2019, 8:02 AM

This revision is now accepted and ready to land.Jun 13 2019, 1:09 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			extension/content-script.js (1 line)
M			host/mprisplugin.h (2 lines)
M			host/mprisplugin.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59580			Jun 11 2019, 8:00 AM	★	★
Diff 2	59728	575c6e9	R856:01a8fa605459923b7919ecb02fa0578e674b048e	Jun 13 2019, 1:09 PM	★	★