Differential D21730

Pass gridLayout pointer to createStyleWidget
AbandonedPublic
Actions

Authored by simgunz on Jun 10 2019, 4:50 PM.

Details

Reviewers: None

Summary

Created by mistake. See D10859.

Diff Detail

Repository

R223 Okular

Branch

fix-annot-config-dialog

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12651
Build 12669: arc lint + arc unit

simgunz created this revision.Jun 10 2019, 4:50 PM

Restricted Application added a project: Okular. · View Herald TranscriptJun 10 2019, 4:50 PM

Restricted Application added a subscriber: okular-devel. · View Herald Transcript

simgunz requested review of this revision.Jun 10 2019, 4:50 PM

Harbormaster completed remote builds in B12651: Diff 59531.Jun 10 2019, 4:50 PM

Whoops, looks like this was supposed to be an update of an existing patch?

shubham added a subscriber: shubham.Jun 10 2019, 4:51 PM

shubham added inline comments.

ui/annotationwidgets.cpp
817	Why not use qobject_cast here and cases above?

simgunz abandoned this revision.Jun 10 2019, 4:53 PM

simgunz edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

			Path	Packages
M			conf/dlgannotationsbase.ui (4 lines)
M			ui/annotationpropertiesdialog.cpp (17 lines)
M			ui/annotationwidgets.h (48 lines)
M			ui/annotationwidgets.cpp (459 lines)

Commit	Tree	Parents	Author	Summary	Date
b24a98f49358	f6daaf112c71	11aa60c51d25	Simone Gaiarin	Set accelerator explicitly (Show More…)	Jun 10 2019, 4:41 PM
11aa60c51d25	758c37d90dd5	2b594d6678ac	Simone Gaiarin	Remove only-for-pdf tooltips	Jun 10 2019, 4:19 PM
2b594d6678ac	86dc09c1a546	84add6535921	Simone Gaiarin	Change string that inform the user about how Identity info are used	Jun 2 2019, 7:15 AM
84add6535921	655a6f5163dc	b911d0ac998b	Simone Gaiarin	Set better accelerators	May 31 2019, 5:49 PM
b911d0ac998b	793fecff9d53	fc1d8c09d877	Simone Gaiarin	Rename "Size" to "Width"	May 31 2019, 5:48 PM
fc1d8c09d877	0ff795bf3ff1	e6924af5acd8	Simone Gaiarin	Add opacity spin to file attachment annotation	May 31 2019, 12:24 PM
e6924af5acd8	e4cdf5cd2997	226904166da8	Simone Gaiarin	Add vertical space to separate groups of settings	May 31 2019, 12:13 PM
226904166da8	44a3730328c5	fffecb23f1e4	Simone Gaiarin	Add color button and opacity spin manually in each annotation (Show More…)	May 31 2019, 12:12 PM
fffecb23f1e4	0c390f223a35	36378c8e7c95	Simone Gaiarin	Make annotation type the first element	May 30 2019, 7:58 PM
36378c8e7c95	a2919ef6e294	adfa68356441	Simone Gaiarin	Same order of Size and Fill color for GeomShape and Polygon	May 30 2019, 7:58 PM
adfa68356441	9459f1100232	73574829a787	Simone Gaiarin	Fix keyboard shortcut of Author conflicts with Add	May 30 2019, 6:59 AM
73574829a787	3c473897fe21	e905ae11384b	Simone Gaiarin	Fix label buddy not working of PixmapPreviewSelector	May 30 2019, 6:46 AM
e905ae11384b	ece969e5a14f	c37832fb73a0	Simone Gaiarin	Align combobox to top	May 29 2019, 7:43 AM
c37832fb73a0	8a5ba3221455	d8d502ac387b	Simone Gaiarin	Move line termination styles before leaders style	May 28 2019, 8:07 PM
d8d502ac387b	ed67064cc317	a4fd1f393756	Simone Gaiarin	Fix wrong widget set as parent	May 28 2019, 8:04 PM
a4fd1f393756	6a2ad926c0ef	2f75be7603ab	Simone Gaiarin	Resort code of line annotation	May 28 2019, 8:04 PM
2f75be7603ab	08813d34ad83	ba7d8076eee2	Simone Gaiarin	Set label alignment and field growth policy	May 28 2019, 5:42 PM
ba7d8076eee2	0c6126a99e66	d6667fb4c505	Simone Gaiarin	Use form layout instead of grid layout	May 28 2019, 5:23 PM
d6667fb4c505	7ca666e9e704	d6e0cd6feb78	Simone Gaiarin	Fix layout of General Info	May 27 2019, 4:11 PM
d6e0cd6feb78	6cb51a174563	1c31054a5dd1	Simone Gaiarin	Fix layout of extraWidget of FileAttachment	May 27 2019, 4:02 PM
1c31054a5dd1	41a4b42f34d7	63fe904a0af6	Simone Gaiarin	Mark variable unused	May 27 2019, 1:54 PM
63fe904a0af6	efd55a5788ce	87c64b21d2f0	Simone Gaiarin	Set buddy	May 27 2019, 1:19 PM
87c64b21d2f0	5af850837b78	f8a4ef81ae43	Simone Gaiarin	Make row variable constant	May 27 2019, 1:07 PM
f8a4ef81ae43	f377216a1539	89f0d646037c	Simone Gaiarin	Rename layout > gridLayout for clarity	May 27 2019, 1:06 PM
89f0d646037c	ea5a551ba5c2	efca3b3375df	Simone Gaiarin	Fix layout of file attachment	May 27 2019, 1:54 PM
efca3b3375df	7cf0fd98ca79	9c14af71a119	Simone Gaiarin	Remove unused code	May 27 2019, 1:00 PM
9c14af71a119	190d8d2af499	e3b96623ff2d	Simone Gaiarin	Fix layout of caret annotation	May 27 2019, 12:58 PM
e3b96623ff2d	a1ac0c818419	676065b6b754	Simone Gaiarin	Fix indentation	May 27 2019, 12:49 PM
676065b6b754	84f69303c84a	7617ef583ace	Simone Gaiarin	Add icon label	May 27 2019, 12:49 PM
7617ef583ace	4b52a6a1b002	7a09cdef31bf	Simone Gaiarin	Remove unuseful return	May 27 2019, 12:45 PM
7a09cdef31bf	fbc5a8ea9f93	25cafd5f9b29	Simone Gaiarin	Fix font capitalization	May 27 2019, 12:42 PM
25cafd5f9b29	465c58df234b	8c6a1620956f	Simone Gaiarin	Fix line endings	May 27 2019, 12:31 PM
8c6a1620956f	c8cf34784ca1	532c340651b7	Simone Gaiarin	Fix layout of stamp	Feb 26 2018, 12:20 PM
532c340651b7	0dbd06ca6e7f	fc3a4133c600	Simone Gaiarin	Simplify code (Show More…)	Feb 26 2018, 12:15 PM
fc3a4133c600	68254a440f3d	9af32cdedead	Simone Gaiarin	Position spacer at the bottom of the grid layout	Feb 26 2018, 12:13 PM
9af32cdedead	53bfbecb913f	b334816d49d4	Simone Gaiarin	Fix layout of straight line and polygon (Show More…)	Feb 26 2018, 12:13 PM
b334816d49d4	50c6b83f7ac8	74cfe98c8af2	Simone Gaiarin	Fix layout of geometrical shape	Feb 26 2018, 11:55 AM
74cfe98c8af2	1695b31ca740	d125831b9de0	Simone Gaiarin	Fix layout of highlighter	Feb 26 2018, 11:41 AM
d125831b9de0	2b801471c280	5bbdacda552d	Simone Gaiarin	Fix layout of freehand tool	Feb 26 2018, 11:38 AM
5bbdacda552d	6e93b33b73ff	bf6c5eae34a3	Simone Gaiarin	Fix design of text annotation tools	May 27 2019, 12:05 PM
bf6c5eae34a3	df52ac15069f	3311ba3a67da	Simone Gaiarin	Pass gridLayout pointer to createStyleWidget	Feb 26 2018, 11:11 AM