Embed kblocksui.rc in Qt resources
Needs ReviewPublic

Authored by aspotashev on Jun 8 2019, 9:54 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Test Plan

menus and toolbars still have the right items

Diff Detail

Repository
R391 KBlocks
Branch
qrc
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12587
Build 12605: arc lint + arc unit
aspotashev created this revision.Jun 8 2019, 9:54 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptJun 8 2019, 9:54 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
aspotashev requested review of this revision.Jun 8 2019, 9:54 PM
aacid added a comment.Jun 8 2019, 10:41 PM

Personally i don't see how this helps at all, but other apps are doing it, so if you're sure it really works you can count my vote as -0

Personally i don't see how this helps at all, but other apps are doing it, so if you're sure it really works you can count my vote as -0

The aim is to run KBlocks without "make install".

aacid added a comment.Jun 8 2019, 10:48 PM

What's the problem with make install? it's literally 1 line

aspotashev added a comment.EditedJun 8 2019, 10:54 PM

What's the problem with make install? it's literally 1 line

  1. I prefer clicking Run in an IDE instead of using command line, especially when using debugger. It takes some steps to configure the IDE to also run "make install".
  2. I'm too lazy to set up a custom prefix, and I don't like self-compiled applications to interfere with the ones installed from the distro.
aacid added a comment.Jun 9 2019, 4:21 PM

this doesn't get you anywhere though, at least you still have themes and the knsrc file that are needed from make install, no?

this doesn't get you anywhere though, at least you still have themes and the knsrc file that are needed from make install, no?

Standard themes can also be moved into qrc (as the second step). knsrc is optional, it's only required once you open the New Hot Stuff dialog.