Create a breeze icon for kfourinline
Needs RevisionPublic

Authored by ognarb on Jun 7 2019, 9:59 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Test Plan

Old:

New:

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12762
Build 12780: arc lint + arc unit
ognarb created this revision.Jun 7 2019, 9:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 7 2019, 9:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ognarb requested review of this revision.Jun 7 2019, 9:59 PM
ognarb edited the test plan for this revision. (Show Details)Jun 7 2019, 10:01 PM
ognarb added a reviewer: VDG.
ognarb updated this revision to Diff 59372.Jun 7 2019, 10:05 PM

Crop shadow

ognarb edited the test plan for this revision. (Show Details)Jun 7 2019, 10:06 PM
ndavis added a subscriber: ndavis.Jun 8 2019, 10:12 AM

We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen thing. How about adding some holes instead to make it look more like the real thing? https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg

Just some ideas: Use light gray or white circles for the holes and black and red for the pieces (like in the actual program). Take a look at the kiriki icon. The way it does indentations can be inspiration for the holes.

I think the icon is lacking gradients, especially the shadows, which are always supposed to be linear gradients.

ngraham added a subscriber: ngraham.Jun 8 2019, 1:40 PM

Also please add a one-pixel hard bottom shadow.

ognarb updated this revision to Diff 59706.Jun 13 2019, 8:42 AM

Still works in progress (need to add the gradiend) but some improvement

ognarb edited the test plan for this revision. (Show Details)Jun 13 2019, 8:42 AM
ognarb updated this revision to Diff 59707.Jun 13 2019, 8:43 AM

Change color of some points

ognarb edited the test plan for this revision. (Show Details)Jun 13 2019, 8:44 AM
ognarb updated this revision to Diff 59720.Jun 13 2019, 11:44 AM

Use more round corner.

ognarb edited the test plan for this revision. (Show Details)Jun 13 2019, 11:44 AM

I just tried the patch on my own computer and I noticed a few more things that need to be changed:

  • The canvas size is 128x128 px when it should be 48x48
  • Strokes need to be converted to paths ( Ctrl+Alt+c ). Strokes don't always look correct in various SVG renderers, including the Qt renderer.
  • I see you added a shadow inside the darker blue rim, but while you can do that, there also needs to be a 1px high shadow on the very bottom for it to match the HIG.
    • There are some exceptions, but they are not common (or the icon creator and reviewers just forgot ¯\_(ツ)_/¯ ).
  • The top left and bottom right corners are not aligned to the grid:


Suggestions regarding the colors:

  • I think the icon would be more recognizable if the board had a darker color instead of a lighter color. The board itself could use a gradient, but I assume you're still planning to add that.
  • For the indentations, I think they would look more natural if their colors were based on the board's colors rather than the pieces' colors.
ndavis requested changes to this revision.Jun 13 2019, 11:08 PM
This revision now requires changes to proceed.Jun 13 2019, 11:08 PM