Display BLAKE2 file checksums for RAR files
ClosedPublic

Authored by nhiga on Jun 7 2019, 3:59 AM.

Details

Summary

When creating a RAR 5.0 archive, BLAKE2sp can be used instead of CRC32 for file checksums. This diff adds an entry for BLAKE2 file checksum.

Test Plan

Attached is a RAR 5.0 archive using BLAKE2sp file checksums.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
nhiga requested review of this revision.Jun 7 2019, 3:59 AM
nhiga created this revision.
nhiga removed a reviewer: kde-utils-devel.
nhiga added subscribers: kde-utils-devel, Ark.

Sorry for the delay. See the inline comment.

part/archivemodel.cpp
188

I wonder if we could use a more descriptive string here. "BLAKE2" will be meaningless to most users. Maybe "Checksum" ?

nhiga added inline comments.Jul 18 2019, 1:13 AM
part/archivemodel.cpp
188

I did not include the word "checksum" for BLAKE2 because I wanted to follow the example of "CRC". But it is true that CRC is more well-known than BLAKE2. Which of the following option is better in your opinion?

  1. Add the word "checksum" to both CRC and BLAKE2:
        case CRC:
	​            return i18nc("CRC hash code", "CRC checksum");
​        case BLAKE2:
	​            return i18nc("BLAKE2 hash code", "BLAKE2 checksum");
  1. Add the word "checksum" to BLAKE2 only:
        case CRC:
	​            return i18nc("CRC hash code", "CRC");
​        case BLAKE2:
	​            return i18nc("BLAKE2 hash code", "BLAKE2 checksum");

I'd go with option 1 ;)

nhiga updated this revision to Diff 62256.Jul 22 2019, 2:35 AM
nhiga marked 2 inline comments as done.
elvisangelaccio accepted this revision.Jul 28 2019, 2:04 PM
This revision is now accepted and ready to land.Jul 28 2019, 2:04 PM
Closed by commit R36:afdf8f2638c7: Display BLAKE2 file checksums for RAR files (authored by Natsumi Higa <r0106.nhiga.kde@protonmail.com>, committed by elvisangelaccio). · Explain WhyJul 28 2019, 3:09 PM
This revision was automatically updated to reflect the committed changes.