Differential D21620

Handle Esc properly when focus is in searchbox
ClosedPublic
Actions

Authored by kishoreg on Jun 6 2019, 2:43 PM.

Details

Reviewers
jgrulich
ngraham
Group Reviewers
Plasma
Commits
R116:5b45ac0edc14: Handle Esc properly when focus is in searchbox
Summary

BUG: 408290

If we place the focus in the searchbar, pressing Esc once dismisses the searchbar. However, pressing Esc after this does not dismiss the popup unless one manually intereacts with some other element in the popup. This patch fixes the issue.

Test Plan
  1. Open the Networks popup in the systray.
  2. Click the search icon above the channels list.
  3. Click in the search area to place focus there.
  4. Press Esc. Searchbar disappears.
  5. Press Esc again. Check that the popup closes.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kishoreg created this revision.Jun 6 2019, 2:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 6 2019, 2:43 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kishoreg requested review of this revision.Jun 6 2019, 2:43 PM
jgrulich accepted this revision.Jun 6 2019, 2:47 PM
This revision is now accepted and ready to land.Jun 6 2019, 2:47 PM
ngraham added a subscriber: ngraham.Jun 6 2019, 3:08 PM

@jgrulich unless you object, I'll land this on the stable branch once my comment has been addressed.

applet/contents/ui/Toolbar.qml
154

Could you add a comment explaining why this is necessary?

jgrulich added a comment.Jun 6 2019, 3:14 PM
In D21620#475194, @ngraham wrote:

@jgrulich unless you object, I'll land this on the stable branch once my comment has been addressed.

Feel free to land it.

kishoreg updated this revision to Diff 59340.Jun 7 2019, 1:15 PM
kishoreg marked an inline comment as done.

Added explanatory comment.

ngraham accepted this revision.Jun 7 2019, 1:54 PM
Closed by commit R116:5b45ac0edc14: Handle Esc properly when focus is in searchbox (authored by kishoreg, committed by ngraham). · Explain WhyJun 7 2019, 2:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/Toolbar.qml (9 lines)

Diff 59345

View Options

applet/contents/ui/Toolbar.qml

Loading...