Differential D21613

Format focal length as milli meter
ClosedPublic
Actions

Authored by astippich on Jun 5 2019, 8:01 PM.

Details

Reviewers
bruns
ngraham
Commits
R286:8823b8a37d02: Format focal length as milli meter

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Jun 5 2019, 8:01 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 5 2019, 8:01 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Jun 5 2019, 8:01 PM
ngraham accepted this revision.Jun 5 2019, 9:50 PM
This revision is now accepted and ready to land.Jun 5 2019, 9:50 PM
bruns added inline comments.Jun 5 2019, 11:23 PM
autotests/propertyinfotest.cpp
145

For small frame cameras (compact cameras, smartphones, ...) the real focal length is often in the range of only a few millimeters, please add a test case which checks e.g. "2.4 mm" is formatted as such.

astippich updated this revision to Diff 59560.Jun 10 2019, 8:48 PM
  • test decimal value
astippich marked an inline comment as done.Jun 10 2019, 8:54 PM
Closed by commit R286:8823b8a37d02: Format focal length as milli meter (authored by astippich). · Explain WhyJun 12 2019, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mautotests/propertyinfotest.cpp (2 lines)

Diff 59677

View Options

autotests/propertyinfotest.cpp

Loading...