Format focal length as milli meter
ClosedPublic

Authored by astippich on Jun 5 2019, 8:01 PM.

Diff Detail

Repository
R286 KFileMetaData
Branch
focal_length
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12665
Build 12683: arc lint + arc unit
astippich created this revision.Jun 5 2019, 8:01 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 5 2019, 8:01 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Jun 5 2019, 8:01 PM
ngraham accepted this revision.Jun 5 2019, 9:50 PM
This revision is now accepted and ready to land.Jun 5 2019, 9:50 PM
bruns added inline comments.Jun 5 2019, 11:23 PM
autotests/propertyinfotest.cpp
144 ↗(On Diff #59223)

For small frame cameras (compact cameras, smartphones, ...) the real focal length is often in the range of only a few millimeters, please add a test case which checks e.g. "2.4 mm" is formatted as such.

astippich updated this revision to Diff 59560.Jun 10 2019, 8:48 PM
  • test decimal value
astippich marked an inline comment as done.Jun 10 2019, 8:54 PM
This revision was automatically updated to reflect the committed changes.