added script for NSIS.
This can be a model blueprint for any other apps trying out the new KNotifications for Windows.
Details
- Reviewers
vonreth albertvaka sredman - Commits
- R877:65be552edff8: Add NSIS Script for KDE Connect
checkout this branch of knotifications in craft : https://phabricator.kde.org/source/knotifications/history/brute4s99%252Fsnore-ftw/
[CraftRoot\etc\blueprints\locations\craft-blueprints-kde]
apply this diff and : https://phabricator.kde.org/D21588
[CraftRoot\craft]
apply this diff to craft : https://phabricator.kde.org/D21615
do craft --package kdeconnect-kde
EXPECTED : The setup created will-
- install shortcut in Start Menu via SnoreToast,
- create shortcut on Desktop for launching KDE Connect.
Diff Detail
- Repository
- R877 Craft Blueprints for KDE
- Branch
- arcpatch-D21602
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12991 Build 13009: arc lint + arc unit
The only thing I immediately see as a problem is the uninstaller doesn't have the proper branding (generic icons), and it didn't uninstall the desktop shortcut
the new diff has correct shortcut installations and removals upon un-installation. be sure to update craft by
craft craft
before testing :)
extragear/kdeconnect-kde/kdeconnect-kde.py | ||
---|---|---|
60 | This one is wrong, see the condition above, I guess we need to update the snorensis script to use the correct context instead |
extragear/kdeconnect-kde/kdeconnect-kde.py | ||
---|---|---|
60 | Wrong, snoretoast needs to allow absolute paths to install, so that the shortcut is installed correctly for all users |
extragear/kdeconnect-kde/kdeconnect-kde.py | ||
---|---|---|
33 ↗ | (On Diff #59353) | I think you should not set the execuatable, firstly he key is deprecated use shortcuts instead and you handle the installation of shortcuts in "sections" |
We still haven't landed KNotifications patch, so I'm waiting on that, since this patch uses SnoreToast call.
We could land it anyway, and instructions related to SnoreToast will just start working after landing the KNotifications patch(es)
ship it.
Snore toast will already get installed but the notifications will be missing.