Would it be make more sense to just have a single file type regex in the config file rather than parsing the existing data and re-processing it in the code?

In D21583#474266, @ngraham wrote:

Would it be make more sense to just have a single file type regex in the config file rather than parsing the existing data and re-processing it in the code?

The config is quite messy in this regard - there are actually two distinct filters in the sources, one for directories and one for files. Currently, both are fed into the same regex, and both are merged into one config key. Also, the config does not diffferentiate between filters deleted from the defaults, or filters added to the defaults, everything is flattened into one config key. This makes config updates quite problematic.

I think having file globs in the config is fine, converting these into regexes wouldn' t be a benefit. Converting the globs into regexes is a insignificant overhead, it is just an implementation detail. Doing the conversion in a low overhead way is nice, but out of scope for the config file syntax.

Ideally, the filter were "default - deleted + added", instead of a flattened list (the config would only save deleted and added filters). File globs are sufficient here.

This change unfortunately does not compile on any platform tracked by the CI system.
Please see https://build.kde.org/job/Frameworks/job/baloo/

This is something which needs correcting relatively urgently, as without it running any Dependency Build job is impossible.

In D21583#475086, @bcooksley wrote:

This change unfortunately does not compile on any platform tracked by the CI system.
Please see https://build.kde.org/job/Frameworks/job/baloo/

This is something which needs correcting relatively urgently, as without it running any Dependency Build job is impossible.

Its always nice to see how easy it is to merge the wrong branch with phabricator ...

This fixes it for me:

diff --git a/src/file/regexpcache.cpp b/src/file/regexpcache.cpp
index f47757ff..dce5cdcb 100644
--- a/src/file/regexpcache.cpp
+++ b/src/file/regexpcache.cpp
@@ -78,9 +78,9 @@ void RegExpCache::rebuildCacheFromFilterList(const QStringList& filters)
     }
 
     // Combine all suffixes into one large RE: "^.*(foo|bar|baz)$"
-    auto suffixMatch = QLatin1String("^.*\\.(");
-    suffixMatch += suffixes.join(QChar('|'));
-    suffixMatch += QLatin1String(")$");
+    auto suffixMatch = QLatin1String("^.*\\.(")
+        + suffixes.join(QChar('|'))
+        + QLatin1String(")$");
     qCDebug(BALOO) << suffixMatch;
     m_regexpCache.prepend(QRegularExpression(suffixMatch));
 }