Differential D21582

Make Playlist items span full width
ClosedPublic
Actions

Authored by ngraham on Jun 4 2019, 5:08 PM.

Details

Reviewers

mgallien

Group Reviewers

Elisa

Commits

R255:fe7d70433b62: Make Playlist items span full width
R255:50bbbfa301c8: Make Playlist items span full width

Summary

Currently playlist items do not span the full width; there is a bunch of
complicated logic to determine the margins and playlist's width. This
makes the display look unbalanced and causes a subtle visual bug
(see BUG: below).

This patch resolves both issues by making playlist items visually stick to
both edges of the playlist, just like the category selector list items do.

This patch also does a bit of necessary code cleanup for the playlist states.
I tested this out quite a bit but to make sure there were no regressions but
it's possible that I missed something so more testing may be needed.

BUG: 408210

Test Plan

Before:

After:

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham requested review of this revision.Jun 4 2019, 5:08 PM

ngraham created this revision.

Harbormaster completed remote builds in B12401: Diff 59140.Jun 4 2019, 5:08 PM

ngraham edited the summary of this revision. (Show Details)Jun 4 2019, 5:12 PM

ngraham edited the test plan for this revision. (Show Details)

The track title left borders are no longer aligned with the album title left border. That makes it harder to read.
In case it is needed, we could also get more feedback from people in VDG and @januz who did the design work for the current playlist layout.

Good point, I'll fix that.

Don't regress vertical alignment of track titles with artist+album name

Harbormaster completed remote builds in B12443: Diff 59210.Jun 5 2019, 5:09 PM

ngraham edited the test plan for this revision. (Show Details)Jun 5 2019, 5:10 PM

Looks good to me. Thanks

This revision is now accepted and ready to land.Jun 6 2019, 8:54 PM

You're welcome!

Closed by commit R255:50bbbfa301c8: Make Playlist items span full width (authored by ngraham). · Explain WhyJun 6 2019, 8:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/qml/ContentView.qml (19 lines)
M			src/qml/MediaPlayListView.qml (5 lines)
M			src/qml/PlayListAlbumHeader.qml (10 lines)
M			src/qml/PlayListEntry.qml (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59140	797a8b8		Jun 4 2019, 5:08 PM	★	★
Diff 2	59210	797a8b8	Don't regress vertical alignment of track titles with artist+album name	Jun 5 2019, 5:09 PM	★	★
Diff 3	59301	797a8b8	R255:50bbbfa301c80d83712fdd10e6328692d21e53e9	Jun 6 2019, 8:59 PM	★	★