Differential D21574

Update KBruch icon
ClosedPublic
Actions

Authored by ognarb on Jun 4 2019, 12:23 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Commits
R266:86d0782cf4e2: Update KBruch icon
Summary

Inspired from application-edu and cantor icon

Test Plan

Old:

New:

Diff Detail

Repository
R266 Breeze Icons
Branch
kbruch
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12393
Build 12411: arc lint + arc unit
ognarb created this revision.Jun 4 2019, 12:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 4 2019, 12:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ognarb requested review of this revision.Jun 4 2019, 12:23 PM
ognarb edited the test plan for this revision. (Show Details)Jun 4 2019, 12:25 PM
ognarb added a reviewer: VDG.
ognarb edited the test plan for this revision. (Show Details)Jun 4 2019, 12:27 PM
ngraham added a subscriber: ngraham.Jun 4 2019, 1:28 PM

Nice! A line of dark pixels on the bottom would help it fit the style even better too. See https://hig.kde.org/style/icon.html#shadows

ognarb updated this revision to Diff 59131.Jun 4 2019, 2:33 PM

Add shadow

ndavis requested changes to this revision.Jun 4 2019, 3:52 PM
ndavis added a subscriber: ndavis.

There needs to be a copy in breeze dark as well. Nice job though!

This revision now requires changes to proceed.Jun 4 2019, 3:52 PM
ndavis added a comment.EditedJun 4 2019, 3:54 PM

Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons.

ognarb added a comment.Jun 4 2019, 3:58 PM
In D21574#474171, @ndavis wrote:

Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons.

Sorry it arc who also uploaded the png that I created for the review, I will fix it.

ndavis added a comment.Jun 4 2019, 4:03 PM
In D21574#474173, @ognarb wrote:

Sorry it arc who also uploaded the png that I created for the review, I will fix it.

Ah, fair enough. Easy mistake to make.

ognarb updated this revision to Diff 59187.Jun 5 2019, 10:59 AM
  • Optimize icon with scour-icon
  • Copy icon to breeze-dark
  • Remove png
ognarb edited the test plan for this revision. (Show Details)Jun 5 2019, 11:01 AM
ndavis accepted this revision.Jun 5 2019, 12:02 PM

LGTM

This revision is now accepted and ready to land.Jun 5 2019, 12:02 PM
Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb). · Explain WhyJun 5 2019, 12:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AM(img)icons/apps/48/kbruch.png
Micons/apps/48/kbruch.svg (3242 lines)

Diff 59131

View Options

icons/apps/48/kbruch.png

Loading...
View Options

icons/apps/48/kbruch.svg

Loading...