The current default path (var/log/samba.log) has not existed in years and is essentially
guaranteed to be wrong. Update the path according to the new location.
Details
Details
- Reviewers
sitter - Group Reviewers
Plasma - Commits
- R102:6243a402c926: Update default Samba log path
Diff Detail
Diff Detail
- Repository
- R102 KInfoCenter
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
https://github.com/samba-team/samba/blame/f33749fc84dacb164d1ac43f6bfcae7afcca34b3/packaging/Example/skeleton.tar looks to me like it has been that way for 21 years. I am inclined to think that the old path may have been some distro specific stuff.
That being said, the path can be configured at will, so ideally it should be read from the config. Which I think we could do since smb.conf looks to be an ini-style config. Something to think about maybe.
Comment Actions
Yes, I had the same thought, but the key's value (/var/log/samba/log.%m) would require some parsing and munging which seems like it could be somewhat fragile.
Comment Actions
True true. I was thinking with the static path as fall back anyway, just the "extra" loveliness of trying to follow the configured path as a first choice.