Differential D21502

[PlasmaComponents3] Vertically center button text as well
ClosedPublic
Actions

Authored by ngraham on May 30 2019, 4:52 PM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Commits

R242:adb999898842: [PlasmaComponents3] Vertically center button text as well

Summary

The PC3 Button's Label didn't have Layout.FillHeight: true set, so button text was not actually
getting vertically centered in certain circumstances. This patch fixes that.

Found while working on D21503.

Test Plan

Before:

After:

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.May 30 2019, 4:52 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 30 2019, 4:52 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.May 30 2019, 4:52 PM

Harbormaster completed remote builds in B12279: Diff 58917.May 30 2019, 4:52 PM

ngraham mentioned this in D21503: [Calculator] Make buttons' text labels scale in size along with the widget.May 30 2019, 4:56 PM

ngraham edited the summary of this revision. (Show Details)May 30 2019, 4:56 PM

ngraham edited the summary of this revision. (Show Details)May 30 2019, 7:13 PM

ngraham edited the summary of this revision. (Show Details)

apol added a subscriber: apol.May 30 2019, 7:57 PM

apol added inline comments.

src/declarativeimports/plasmacomponents3/Button.qml
56	With it being a RowLayout, shouldn't fillHeight be always true?

ngraham added inline comments.May 30 2019, 10:10 PM

src/declarativeimports/plasmacomponents3/Button.qml
56	Apparently not, because explicitly adding this does make a difference, as the before-and-after images show.

broulik added a subscriber: broulik.May 30 2019, 10:14 PM

broulik added inline comments.

src/declarativeimports/plasmacomponents3/Button.qml
56	I think he was asking why not just make it `true` unconditionally

Oh haha

Always fill height

Harbormaster completed remote builds in B12288: Diff 58931.May 31 2019, 3:23 AM

ngraham marked 3 inline comments as done.May 31 2019, 3:23 AM

broulik accepted this revision.Jun 3 2019, 4:04 PM

This revision is now accepted and ready to land.Jun 3 2019, 4:04 PM

Closed by commit R242:adb999898842: [PlasmaComponents3] Vertically center button text as well (authored by ngraham). · Explain WhyJun 3 2019, 4:07 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in R114:987f5fe9bb12: [Calculator] Make buttons' text labels scale in size along with the widget.

Revision Contents
Changeset List

			Path	Packages
M			src/declarativeimports/plasmacomponents3/Button.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58917	09fa87a		May 30 2019, 4:52 PM	★	★
Diff 2	58931	09fa87a	Always fill height	May 31 2019, 3:23 AM	★	★
Diff 3	59078	b3bb412	R242:adb9998988427b836456e5dafbe910cacb4d3c26	Jun 3 2019, 4:06 PM	★	★

Diff 59078

View Options

src/declarativeimports/plasmacomponents3/Button.qml