The PC3 Button's Label didn't have Layout.FillHeight: true set, so button text was not actually
getting vertically centered in certain circumstances. This patch fixes that.
Found while working on D21503.
broulik |
Plasma |
The PC3 Button's Label didn't have Layout.FillHeight: true set, so button text was not actually
getting vertically centered in certain circumstances. This patch fixes that.
Found while working on D21503.
Before:
After:
No Linters Available |
No Unit Test Coverage |
Buildable 12288 | |
Build 12306: arc lint + arc unit |
src/declarativeimports/plasmacomponents3/Button.qml | ||
---|---|---|
56 ↗ | (On Diff #58917) | With it being a RowLayout, shouldn't fillHeight be always true? |
src/declarativeimports/plasmacomponents3/Button.qml | ||
---|---|---|
56 ↗ | (On Diff #58917) | Apparently not, because explicitly adding this does make a difference, as the before-and-after images show. |
src/declarativeimports/plasmacomponents3/Button.qml | ||
---|---|---|
56 ↗ | (On Diff #58917) | I think he was asking why not just make it true unconditionally |