BUG: 132158
BUG: 148357
BUG: 407318
FIXED-IN: 19.08.0
Details
Diff Detail
- Repository
- R353 KCalc
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Adding Evan since he knows best what prevented the use of MPFR when the code was initially added.
CMakeLists.txt | ||
---|---|---|
63 | Why required? The code is full of #ifdef KNUMBER_USE_MPFR, so it could be made to work in either case. |
CMakeLists.txt | ||
---|---|---|
63 | Sorry, I did not pay attention to this. |
Thanks.
Honestly, it was disabled by default just because it was new and I didn't want any difference in behavior seemingly out of nowhere. The code is probably pretty good, though i expect some regression tests will have different results due to the difference in precision.
I'm attaching the output generated by knumbertest.
Is there any other tests I can run to ensure it's all ok?
Evan, any objections? I would like to commit it to master branch.
Marcelo, please add a comment to bug 407318 with a link to this phabricator page. The mail address is used for the author attribution.