If the desktops are already visible, there's no much need to hold on the KSplash. Panels should be ellegantly displayed when they're ready.
As discussed in T10958.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:627a2216b7b6: Close KSplash when the desktops are visible
Made sure that it gets emitted at the right time.
Timing-wise, my system takes about 1s to show the DesktopView and 2s to show the PanelView (I have 1 panel)
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Whilst I love this patch, I think we may need another patch somewhere in the stack to make the desktops not announce they're done till they've actually loaded their wallpaper.
Comment Actions
I was looking into this, this is something that it's not yet available at the very least. WallpaperInterface::loadFinished is called very early in the process, much earlier than the ui is ever ready.
Comment Actions
Also mind that we load the image asynchronously, so maybe we need a signal that a wallpaper plugin can emit to signal it's ready.
Perhaps have the QML define a signal loadingFinished and connect from c++ and only if it's present wait for it (for compat). The QML will then do onStatusChanged: if (status !== Image.Loading) root.loadingFinished()