| mgallien |
| Elisa |
When I did D20581, I forgot to do the File Browser view too. This patch ports the UI
changes done in D20581.
Side note: it feels like these two delegates should really be using the same paramaterized
components rather than mostly sharing the same code which must then be kept in sync. This
one also has no test coverage; even more reason to move towards using the GridBrowserDelegate
for both.
BUG: 407945
Tests still pass; UI now looks the same as the grid items in other views
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I branched off of 0.4 as this seems like a bugfix, but if approved it could probably go only into master instead.
Thanks for having taken care of that.
I see that there is changes with the translated strings.
In order to be able to deliver this quickly, I can think about two possible options:
My preferred option is the second one. What do you think ?
Overall, the file browser support looks a bit broken in my setup (at least for music not indexed by baloo). Can you confirm ?
| src/qml/FileBrowserDelegate.qml | ||
|---|---|---|
| 167 | In order to be able to have it in the bugfix branch, it is probably needed to put back the comment. | |
The file browser *mostly* works fine for me with the 0.4 release + this patch. I can file bugs if you'd like.
I can revert any changes that add new translated strings, how about that? I mostly changed these strings to be the same as in the other grid delegate so it shouldn't be hard to avoid adding any new strings. Do you think that makes sense?
Yes please.
I can revert any changes that add new translated strings, how about that? I mostly changed these strings to be the same as in the other grid delegate so it shouldn't be hard to avoid adding any new strings. Do you think that makes sense?
That would be perfect. Thanks
Actually, testing again, this patch fixed all the outstanding issues I found with the Folder Browser. \o/