Details
- Reviewers
dfaure - Group Reviewers
KDE PIM - Commits
- R94:bce8cd755c16: Run grantleeheaderstyletest without kdepim-addons and without pre installat…
Diff Detail
- Repository
- R94 PIM: Message Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
messageviewer/src/antispam/antispamconfig.cpp | ||
---|---|---|
65 | Won't this affect the regular code, though? |
messageviewer/src/antispam/antispamconfig.cpp | ||
---|---|---|
65 | Yes, I think so and I'm unsure what is the outcome of such a change. Can I check if we are in TestMode and disable this only when on testMode? |
messageviewer/src/antispam/antispamconfig.cpp | ||
---|---|---|
65 | qputenv in the test and qgetenv here. Or make the test closer to the regular case ;-) |
messageviewer/src/antispam/antispamconfig.cpp | ||
---|---|---|
65 |
thx for the tips.
Well I want the tests to be working without installation and as non root I can't write to /usr/share. So I would need to control the default location and I don't see a way to achieve this.
This I'm wondering, too. I tracked this line of code exists from the beginning of the git history and this file was added 2004 and that line was never touched since then. The commit message is: I would suggest to remove this line as it seems to me, that it breaks stuff (e.g. our tests) and I can't imagine what we gain if we keep this line intact. With removing the line we gain the possibility for users to change the "kmail.antispamrc" for their needs. |