Fix CI failure in autotest grantleeheaderstyletest
AbandonedPublic

Authored by gjditchfield on Aug 15 2019, 1:29 AM.

Details

Reviewers
knauss
Summary

grantleeheaderstyletest passes all tests in the KDE PIM Docker environment,
but fails in CI because it does not find an expected Spamassassin header
in some HTML-formatted output. It seems likely that the style cannot process
the message's spam headers because the antispam plugins are not installed
in the test environment.

This patch removes spam headers from the mbox file and the expected HTML
output, so the test will behave the same in the KDE PIM Docker and the
CI test environment.

I think it would still be a good idea to test that spam headers are
formatted correctly, so I will submit a companion patch that performs the
test in kdepim-addons, where the antispam plugins will be present.

Diff Detail

Repository
R94 PIM: Message Library
Branch
grantleeheaderstyle (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15123
Build 15141: arc lint + arc unit
gjditchfield created this revision.Aug 15 2019, 1:29 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 15 2019, 1:29 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
gjditchfield requested review of this revision.Aug 15 2019, 1:29 AM
knauss added a subscriber: knauss.Aug 18 2019, 8:37 AM

This is not the way it should be fixed. I already added a patch that fixes that issue (but havn't commited it yet).

see D21444

knauss requested changes to this revision.Aug 23 2019, 11:43 AM

The CI is now fixed so we don't have to move the test.

This revision now requires changes to proceed.Aug 23 2019, 11:43 AM