Differential D21436

Use onClicked for Home button
ClosedPublic
Actions

Authored by GB_2 on May 27 2019, 7:08 PM.

Details

Reviewers
ngraham
apol
Group Reviewers
Plasma
VDG
Commits
R134:66f3bec02825: Use onClicked for Home button
Summary

BUG: 407636
FIXED-IN: 5.16.0

Buttons should use onClicked instead of onPressed.

Test Plan

Click on the Home button. It now behaves correctly.

Diff Detail

Repository
R134 Discover Software Store
Branch
use-onclicked-for-home-button (branched from Plasma/5.16)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12199
Build 12217: arc lint + arc unit
GB_2 created this revision.May 27 2019, 7:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 27 2019, 7:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.May 27 2019, 7:08 PM
ngraham accepted this revision.May 28 2019, 3:18 AM
ngraham added a subscriber: ngraham.

My bad!

This revision is now accepted and ready to land.May 28 2019, 3:18 AM
apol accepted this revision.May 28 2019, 11:04 AM
Closed by commit R134:66f3bec02825: Use onClicked for Home button (authored by GB_2). · Explain WhyMay 28 2019, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/DiscoverDrawer.qml (2 lines)

Diff 58739

View Options

discover/qml/DiscoverDrawer.qml

Loading...