[Notifications] Don't show blue icon when a notification is active
ClosedPublic

Authored by broulik on Mon, May 27, 7:58 AM.

Details

Summary

Also consider a notification as unread only when it isn't active anymore.

Test Plan

notify-send foo bar, waited for popup to close, got a "1" in my panel
notify-send foo bar, closed the popup, didn't get anything in my panel
As suggested by VDG

I originally had the notification plasmoid show up alongside the popup to kinda indicate "this is where this thing is coming from/going to". With this change the notification plasmoid will not be shown in the panel unless there is an unread notification.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mon, May 27, 7:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, May 27, 7:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mon, May 27, 7:58 AM
ndavis accepted this revision.Mon, May 27, 12:09 PM
ndavis added a subscriber: ndavis.

LGTM

This revision is now accepted and ready to land.Mon, May 27, 12:09 PM
ngraham accepted this revision.Tue, May 28, 4:08 AM
This revision was automatically updated to reflect the committed changes.