QuickOpen: Select first item on show
ClosedPublic

Authored by michalhumpula on May 25 2019, 3:16 PM.

Details

Reviewers
cullmann
dhaumann
Summary

Should be the last item to fix the 407103, i.e. when showing quick open, the first item in model should be selected. That way when hitting the enter right after the show, the kate won't create empty file but rather select first (most likely already open) file.

BUG: 407103

Test Plan

It's not working the way it's described in the issue, but I think the behavior of having the selected first item from the list is sane and user has visual information about that selection so she should not be surprised anymore.

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
michalhumpula created this revision.May 25 2019, 3:16 PM
Restricted Application added a project: Kate. · View Herald TranscriptMay 25 2019, 3:16 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
michalhumpula requested review of this revision.May 25 2019, 3:16 PM

Sigh... I wish KDE would use something like gitlab at this point. According to this https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords it should be sufficient to add BUG: 407103 to the summary to link the issue in bugzila, but nothing has happened. What did I miss? I hope theese still works? https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

michalhumpula retitled this revision from Select first item on sho to QuickOpen: Select first item on show.May 25 2019, 3:21 PM
apol added a subscriber: apol.May 25 2019, 4:30 PM

It links once it's pushed.

In D21405#470000, @apol wrote:

It links once it's pushed.

Ok, thanks for the info. Should I then link the patch review manually to bugzilla ticket in order to signalize that it's being worked on?

cullmann accepted this revision.May 25 2019, 6:18 PM

Just push it.

This revision is now accepted and ready to land.May 25 2019, 6:18 PM
dhaumann accepted this revision.May 25 2019, 9:18 PM