Port to ECMAddQmlModule
AcceptedPublic

Authored by kossebau on May 22 2019, 5:55 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Summary

While the current logic for Plasma QML modules is stable and all repeated
data has been already repeated, porting to the new macros of ECMAddQmlModule
can help others to learn about the macros and how to use them.

Perhaps there could also be a special macro for the generation stuff being
done for components3, for that some other potential users would be first
good to have to know more patterns.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
porttoECMInstallQmlModules
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12759
Build 12777: arc lint + arc unit
kossebau created this revision.May 22 2019, 5:55 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 22 2019, 5:55 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 22 2019, 5:55 PM
kossebau updated this revision to Diff 58492.May 22 2019, 5:57 PM

also remove include of ECMGenerateQmlTypes, newer macros cover that as well

kossebau added a comment.EditedMay 22 2019, 6:10 PM

The diff between the generated qmldir files and the manually written ones looks good. And also showed the one of plasmacore has some left-over (see D21350)

src/declarativeimports/plasmacomponents/CMakeLists.txt
37

All the repeated names make me wonder if the macro could be made even more nice by having it autoderive the type name from the file. At least all the files in Plasma and the mojority in my own projects match this naming pattern.

As that might blow up the macro code a bit, first waiting for principal feedback.

kossebau updated this revision to Diff 58597.May 24 2019, 1:29 PM

udate to latest master

kossebau updated this revision to Diff 59701.Jun 13 2019, 12:22 AM

update to latest ecm_add_qmlmodule draft

apol accepted this revision.Jun 13 2019, 12:32 AM
apol added a subscriber: apol.

I like it :)

This revision is now accepted and ready to land.Jun 13 2019, 12:32 AM