Differential D21293

Markdown: Use color with higher contrast for lists
ClosedPublic
Actions

Authored by dhaumann on May 19 2019, 3:58 PM.

Details

Reviewers
cullmann
gregormi
Commits
R216:7be1380c52a8: Markdown: Use color with higher contrast for lists
Summary

BUG: 405824
FIXED-IN: 5.59

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.May 19 2019, 3:58 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMay 19 2019, 3:58 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.May 19 2019, 3:58 PM
dhaumann added a comment.May 19 2019, 3:59 PM

New color is red:

@gregormi If you want other colors, please propose them yourself :-)

cullmann accepted this revision.May 19 2019, 4:00 PM

Looks ok for me.

This revision is now accepted and ready to land.May 19 2019, 4:00 PM
Closed by commit R216:7be1380c52a8: Markdown: Use color with higher contrast for lists (authored by dhaumann). · Explain WhyMay 19 2019, 4:02 PM
This revision was automatically updated to reflect the committed changes.
gregormi added a comment.EditedMay 19 2019, 6:26 PM
In D21293#467150, @dhaumann wrote:

New color is red:

@gregormi If you want other colors, please propose them yourself :-)

Thanks. Let's see how it works out.

Regarding the screenshot, I see that "code 1, code2" is also the same orange as list items previously were. I think it would be better to change that as well, e.g. to blue as in "block quote" but a darker.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 58309