Differential D21288

Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type
ClosedPublic
Actions

Authored by nibags on May 19 2019, 11:35 AM.

Details

Reviewers
dhaumann
cullmann
Group Reviewers
Framework: Syntax Highlighting
Commits
R216:71446d3e9e5e: Remove .conf extension from "INI Files" hl, to determine the highlighter using…
Summary

BUG: 400290

The extension .conf is very generic, since depending on the context, it can be used with a different language, and assigning it to the "INI Files" highlighter isn't very convenient.
For example, in "Fontconfig" the XML files have a .conf extension.

Therefore, I propose that the .conf extension isn't assigned to any syntax highlighter, so use the MIME type to determine the highlighting mode in those files.

For example, when applying this patch, the Fontconfig files (located in /etc/fonts/) are highlighted as XML by default.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nibags created this revision.May 19 2019, 11:35 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMay 19 2019, 11:35 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.May 19 2019, 11:35 AM
cullmann accepted this revision.May 19 2019, 11:41 AM

OK with that.

This revision is now accepted and ready to land.May 19 2019, 11:41 AM
Closed by commit R216:71446d3e9e5e: Remove .conf extension from "INI Files" hl, to determine the highlighter using… (authored by nibags). · Explain WhyMay 19 2019, 11:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdata/syntax/ini.xml (2 lines)

Diff 58295

View Options

data/syntax/ini.xml

Loading...