Differential D2125

Fix Title Flickering on Document Change
ClosedPublic
Actions

Authored by cordlandwehr on Jul 9 2016, 8:06 PM.

Details

Reviewers
mwolff
brauch
kfunk
Group Reviewers
KDevelop
Commits
R33:386991aa25e5: Fix Title Flickering on Document Change
R32:386991aa25e5: Fix Title Flickering on Document Change
Summary

Use new option from KF5 24 to disable KPart's title handling.
This prevents KPart to act on changed KTextEditor documents by
setting a title different to the one KDevelop wants to set.

Test Plan

Manual testing.

Diff Detail

Repository
R33 KDevPlatform
Branch
fixTitleFlickering
Lint
No Linters Available
Unit
No Unit Test Coverage
cordlandwehr updated this revision to Diff 5048.Jul 9 2016, 8:06 PM
cordlandwehr retitled this revision from to Fix Title Flickering on Document Change.
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added reviewers: KDevelop, kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 9 2016, 8:07 PM
mwolff requested changes to this revision.Jul 10 2016, 11:37 AM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

-1, this must be handled optionally - I don't want us to depend on a just released framework yet.

This revision now requires changes to proceed.Jul 10 2016, 11:37 AM
cordlandwehr updated this revision to Diff 5058.Jul 10 2016, 12:56 PM
cordlandwehr edited edge metadata.
  • Make KF5 5.24 requirement optional
mwolff requested changes to this revision.Jul 10 2016, 10:04 PM
mwolff edited edge metadata.
mwolff added inline comments.
CMakeLists.txt
75

please use a config file and configure_file (don't we do that already somewhere?)

also, call it HAS_KF5_24. Furthermore, aren't there version headers for the frameworks which you could include and use in the code directly?

This revision now requires changes to proceed.Jul 10 2016, 10:04 PM
kfunk requested changes to this revision.Jul 11 2016, 8:36 AM
kfunk edited edge metadata.

Yeah, there's a kparts_version.h you can just include.

cordlandwehr updated this revision to Diff 5082.Jul 11 2016, 6:26 PM
cordlandwehr edited edge metadata.

Use KParts version header.

brauch accepted this revision.Jul 11 2016, 6:29 PM
brauch added a reviewer: brauch.
brauch added a subscriber: brauch.

Looks good to me. Thanks.

Closed by commit R33:386991aa25e5: Fix Title Flickering on Document Change (authored by cordlandwehr). · Explain WhyJul 12 2016, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (3 lines)
Mshell/mainwindow.cpp (7 lines)

Diff 5058

View Options

CMakeLists.txt

Loading...
View Options

shell/mainwindow.cpp

Loading...