Differential D21173

API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'
ClosedPublic
Actions

Authored by kossebau on May 12 2019, 11:31 PM.

Details

Reviewers
dhaumann
Group Reviewers
Plasma
Commits
R242:9142155b5a5b: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 12 2019, 11:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 12 2019, 11:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 12 2019, 11:31 PM
apol added a subscriber: apol.May 13 2019, 11:21 AM
apol added inline comments.
src/plasma/framesvg.h
230

"appended" reads weird.

How about including a '-' at the end if not empty?

kossebau updated this revision to Diff 58006.May 13 2019, 2:52 PM

appended -> at the end

dhaumann accepted this revision.May 13 2019, 4:24 PM
This revision is now accepted and ready to land.May 13 2019, 4:24 PM
Closed by commit R242:9142155b5a5b: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-' (authored by kossebau). · Explain WhyMay 13 2019, 9:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.h (6 lines)

Diff 58036

View Options

src/plasma/framesvg.h

Loading...