Differential D21157

handle maps with multiple or single entries from Baloo
ClosedPublic
Actions

Authored by astippich on May 12 2019, 2:18 PM.

Details

Reviewers
elvisangelaccio
bruns
Group Reviewers
Dolphin
Commits
R318:36b61838a27d: handle maps with multiple or single entries from Baloo
Summary

Handle maps which may contain multiple entries with the same key.
Bumps frameworks to 5.58. Equivalent to D20739.

Diff Detail

Repository
R318 Dolphin
Branch
baloo_entries
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12032
Build 12050: arc lint + arc unit
astippich created this revision.May 12 2019, 2:18 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 12 2019, 2:18 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
astippich requested review of this revision.May 12 2019, 2:18 PM
astippich retitled this revision from handle maps with multiple or single entries from KFileMetaData to handle maps with multiple or single entries from Baloo.May 12 2019, 2:21 PM
elvisangelaccio added inline comments.May 19 2019, 9:41 AM
src/kitemviews/private/kbaloorolesprovider.cpp
62 ↗(On Diff #57931)

Maybe we could call this variable rangeBegin to be consistent with rangeEnd below?

66 ↗(On Diff #57931)

While at it, I'd rename this variable to propertyInfo to better explain its role.

astippich updated this revision to Diff 58433.May 21 2019, 6:27 PM
  • rename variables
elvisangelaccio accepted this revision.May 25 2019, 3:25 PM
This revision is now accepted and ready to land.May 25 2019, 3:25 PM
bruns accepted this revision.May 25 2019, 3:30 PM

Don't forget to adjust @since 5.xx

astippich added a comment.May 26 2019, 7:41 AM
In D21157#469953, @bruns wrote:

Don't forget to adjust @since 5.xx

Could you be a little bit more specific? This does not add a new method or something like that

Closed by commit R318:36b61838a27d: handle maps with multiple or single entries from Baloo (authored by astippich). · Explain WhyMay 30 2019, 9:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58433

View Options

CMakeLists.txt

Loading...
View Options

src/kitemviews/private/kbaloorolesprovider.cpp

Loading...