Differential D21120

Fix memory leak of ItemRetrievalJobFactory in ItemRetrievalManager
ClosedPublic
Actions

Authored by dfaure on May 10 2019, 11:05 AM.

Details

Reviewers
dvratil
Commits
R165:c2c92eb9aaa8: Fix memory leak of ItemRetrievalJobFactory in ItemRetrievalManager
Summary

It was never deleted. Fixed by making the ItemRetrievalManager own
the ItemRetrievalJobFactory in all cases.

Test Plan

ctest -R AkonadiServer-itemretrievertest in an ASAN build

Diff Detail

Repository
R165 Akonadi
Branch
Applications/19.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11719
Build 11737: arc lint + arc unit
dfaure created this revision.May 10 2019, 11:05 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 10 2019, 11:05 AM
dfaure requested review of this revision.May 10 2019, 11:05 AM
dvratil accepted this revision.May 10 2019, 11:23 AM
This revision is now accepted and ready to land.May 10 2019, 11:23 AM
Closed by commit R165:c2c92eb9aaa8: Fix memory leak of ItemRetrievalJobFactory in ItemRetrievalManager (authored by dfaure). · Explain WhyMay 10 2019, 11:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57851

View Options

autotests/server/itemretrievertest.cpp

Loading...
View Options

src/server/storage/itemretrievalmanager.h

Loading...
View Options

src/server/storage/itemretrievalmanager.cpp

Loading...