Use the new signal-slot connect syntax
Details
- Reviewers
aacid - Group Reviewers
Okular - Commits
- R223:745e8dfa8bb1: use the new signal-slot connect syntax
Diff Detail
- Repository
- R223 Okular
- Lint
Lint Skipped - Unit
Unit Tests Skipped
please use QOverload<int>::of() instead of static_cast<void (QComboBox::*)(int)> much easier to read.
ui/annotationwidgets.cpp | ||
---|---|---|
543 | Why this change? |
@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?
See poppler API
void setLineStartStyle( TermStyle style ); void setLineEndStyle( TermStyle style );
and XML attributes "startStyle" and "endStyle".
Certainly. I did notice the startStyle as well, but decided to ignore it for the time being.
I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?
I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?
IMO it would be okay. Plus, with the help of Tobias maybe you can even teach Okular how to draw the start/end markers for non-pdf documents in a separate patch? I remember him saying that that is not very difficult.
Yes, I'm slowly working on it. As I understand we have time until 19.08 tagging to make non-PDF line end drawing work and remove the tooltip again. That should be doable, so ideally no user will ever see "PDF only" in a released version of Okular. If we're too slow, the tooltip is kind of backup. If Albert or Nate disagree, their opinion should have more weight.