Symlink arrow-*-double to go-*-skip
ClosedPublic

Authored by ndavis on May 7 2019, 8:52 AM.

Details

Summary

Previously, the arrow-*-double icons were symlinked to go-top/bottom/first/last icons, which aren't really double arrows. go-*-skip icons are real double arrows.

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.May 7 2019, 8:52 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 7 2019, 8:52 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.May 7 2019, 8:52 AM
ndavis edited the test plan for this revision. (Show Details)May 7 2019, 8:54 AM
ngraham accepted this revision.May 7 2019, 2:00 PM
This revision is now accepted and ready to land.May 7 2019, 2:00 PM
This revision was automatically updated to reflect the committed changes.

I've reverted this commit as it breaks compilation
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/78/console
[ 79%] Generating res/breeze-icons.qrc
15:58:48 Error copying directory from "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/icons" to "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build/icons/res".

https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/

ndavis added a comment.May 7 2019, 4:51 PM

Whoops. Forgot there were no 24px go-*-skip icons. I'll have to fix that and then the patch will work.