Round the cell width to avoid getting blurry previews.
Details
Details
Before:
After:
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- no-blurry-previews-widget-explorer (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11580 Build 11598: arc lint + arc unit
desktoppackage/contents/explorer/WidgetExplorer.qml | ||
---|---|---|
295 ↗ | (On Diff #57588) | In general it's best to use floor rather than round for this kind of thing to prevent everything from getting rounded up and potentially overflowing the bounds. |
Comment Actions
I was thinking 5.15 only, but 5.12 too is probably fine for a focused change like this.
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
Comment Actions
Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
I can help with this in the future. It can be tricky.